General Discussion

Dragon - Hydregion
Grass - Bayleaf
Fire - The Torchic Line
Fairy - Spritzee
Water - Empoleon/Lanturn
Dark - Houndour/Houndoom and Poochyena/Mightyena
Ghost - Trevenant
Electric - Luxio
Ground - Flygon
Steel - Skarmory
Fighting - Mienshao
Fliying - Swellow
Ice - Cubchoo/Beartic
Poison - Nidoran/Nidoking
Bug - Scolipede/Scyther
Psychic - Meowstic/Gardevoir
Normal - Loudred/Glameow

Dragon Dragonair
Grass Weepinbell
Fire Darmanitan
Fairy Sylveon
Water Whiscash
Dark Honchkrow
Ghost Rotom
Electric Jolteon
Ground Gliscor
Steel Empoleon
Fighting Heracross
Flying Hawlucha
Ice Articuno
Poison Scolipede
Bug Joltik
Psychic Xatu
Normal Zangoose
Rock Relicanth

Bet you can't guess what my favorite is. >__>

Dragon - Hydreigon
Grass - Serperior
Fire - Entei
Fairy - Gardevoir
Water - Cloyster
Dark - Darkrai
Ghost - GENGAR GENGAR GENGAR
Electric - Galvantula
Ground - Zygarde
Steel - Aegislash
Fighting - Gallade
Flying - Rayquaza
Ice - Glaceon
Poison - GENGAR IS LOVE, GENGAR IS LIFE
Bug - Galvantula
Psychic - Gardevoir/Gallade
Normal - Eevee

I picked an additional non-legendary pokemon when my favorite was a legendary.

Dragon: Rayquaza/Salamence
Grass: Sceptile
Fire: Charizard
Fairy: Xerneas/Togepi
Water: Feraligatr
Dark: Tyranitar
Ghost: Giratina/Aegislash
Electric: Zapdos/Heliolisk
Ground: Groudon/Flygon
Steel: Dialga/Aggron or Bastiodon
Fighting: Hawlucha
Flying: Aerodactyl or Archeops
Ice: Kyurem(normal form)/Aurorus
Poison: Seviper or Drapoin or Nidoking
Bug: Scyther or Armaldo
Psychic: Lugia/Metagross
Normal: Kecleon
Rock: Tyrantrum *All time favourite pokemon*

Favorite
Dragon: Tyrantum
Grass: Leafeon
Fire: Chandelure
Fairy: Don't really have on yet
Water: Totodile all the way
Dark: Murkrow
Ghost: Banette
Electric: Ampharos
Ground: Krookodile
Steel : Scizor
Fighting : Pangoro
Flying : Honchkrow
Ice :Articuno
Poison : Whezing (the first shiny I found, way back in Silver)
Bug: Forretres
Psychic : Gallade
Normal : Meowth (saving my Nuzlocke run!)
Rock : Golem

Favorite
Dragon Tyrantrum
Grass Lileep
Fire Typhlosion
Fairy Togepi
Water Carracosta
Dark Skuntank
Ghost Drifloon
Electric Joltik
Ground Excadrill
Steel Aggron
Fighting Chesnaught
Flying Pidgeot
Ice Cubchoo
Poison Nidoqueen
Bug Vespiquen
Psychic Claydol
Normal Kangaskhan! my top-favorite pokemon x)
Rock Tyranitar

Dragon - Altaria
Grass - Meganium
Fire - All evolutions of Torchic
Fairy - Snubbull
Water - Seadra
Dark - Houndoom
Ghost - Misdreavus
Electric - Jolteon
Ground - Gliscor
Steel - Aggron
Fighting - Blaziken
Flying - Swellow, Noctowl, and Pidgeot (literally could not choose)
Ice - Dewgong
Poison - Gengar
Bug - Scyther
Psychic - Espeon
Normal - Braviary
Rock - Tyrantrum (...and Tyranitar)